Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Scheduler] silence PHP warning when an invalid date interval format string is used #58550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2024
Merged

[Scheduler] silence PHP warning when an invalid date interval format string is used #58550

merged 1 commit into from
Oct 13, 2024

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Oct 13, 2024

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

@xabbuh xabbuh requested a review from kbond as a code owner October 13, 2024 07:54
@carsonbot carsonbot added this to the 6.4 milestone Oct 13, 2024
@xabbuh xabbuh force-pushed the periodical-trigger-date-interval-silence-warning branch from 192921c to dc43906 Compare October 13, 2024 08:13
@OskarStark
Copy link
Contributor

So more "throwing exception if invalid ...." ? It's the opposite from silencing to me 😂

@xabbuh
Copy link
Member Author

xabbuh commented Oct 13, 2024

We silence the PHP warning and then throw an exception that we already throw when PHP 8.3+ is used.

@fabpot
Copy link
Member

fabpot commented Oct 13, 2024

Thank you @xabbuh.

@fabpot fabpot merged commit 5720bac into symfony:6.4 Oct 13, 2024
10 checks passed
@xabbuh xabbuh deleted the periodical-trigger-date-interval-silence-warning branch October 13, 2024 13:01
This was referenced Oct 27, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@kbond kbond Awaiting requested review from kbond kbond is a code owner

Assignees
No one assigned
Labels
Bug Scheduler Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @OskarStark @fabpot @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.