[Validator] Add Slug constraint
#58542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
588b94a to
bd741b8
Compare
stof
reviewed
Nov 20, 2024
fabpot
requested changes
Jan 5, 2025
4bb94c8 to
0193d0c
Compare
fabpot
reviewed
Jan 5, 2025
5029028 to
ef1188d
Compare
Done |
fabpot
approved these changes
Jan 5, 2025
ef1188d to
6233382
Compare
|
Thank you @raffaelecarelle. |
|
Hey, are we fine with |
stof
reviewed
Apr 29, 2025
| { | ||
| public const NOT_SLUG_ERROR = '14e6df1e-c8ab-4395-b6ce-04b132a3765e'; | ||
|
|
||
| public string $message = 'This value is not a valid slug.'; |
There was a problem hiding this comment.
This message needs to be added in translation files (so that the translators from the community can provide translations for it in core, like other default messages of constraints)
There was a problem hiding this comment.
this has already been done in #59383
Merged
nicolas-grekas
added a commit
that referenced
this pull request
May 16, 2025
…results (xabbuh) This PR was merged into the 7.3 branch. Discussion ---------- [Validator] let the `SlugValidator` accept `AsciiSlugger` results | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Fix #58542 (comment) | License | MIT Commits ------- d51f563 let the SlugValidator accept AsciiSlugger results
symfony-splitter
pushed a commit
to symfony/validator
that referenced
this pull request
May 16, 2025
…results (xabbuh) This PR was merged into the 7.3 branch. Discussion ---------- [Validator] let the `SlugValidator` accept `AsciiSlugger` results | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Fix symfony/symfony#58542 (comment) | License | MIT Commits ------- d51f563ed3c let the SlugValidator accept AsciiSlugger results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce Slug constraint class for validating strings as slugs.
Add unit tests to verify correct behavior for valid and invalid slugs.