diff --git a/src/Symfony/Bridge/Monolog/Handler/ChromePhpHandler.php b/src/Symfony/Bridge/Monolog/Handler/ChromePhpHandler.php index 16c082f11b8b1..ce420bd8ef3cc 100644 --- a/src/Symfony/Bridge/Monolog/Handler/ChromePhpHandler.php +++ b/src/Symfony/Bridge/Monolog/Handler/ChromePhpHandler.php @@ -40,7 +40,7 @@ public function onKernelResponse(ResponseEvent $event) return; } - if (!preg_match(static::USER_AGENT_REGEX, $event->getRequest()->headers->get('User-Agent'))) { + if (!preg_match(static::USER_AGENT_REGEX, $event->getRequest()->headers->get('User-Agent', ''))) { self::$sendHeaders = false; $this->headers = []; diff --git a/src/Symfony/Bridge/Monolog/Tests/Handler/ChromePhpHandlerTest.php b/src/Symfony/Bridge/Monolog/Tests/Handler/ChromePhpHandlerTest.php new file mode 100644 index 0000000000000..a83ef9eb6cbd5 --- /dev/null +++ b/src/Symfony/Bridge/Monolog/Tests/Handler/ChromePhpHandlerTest.php @@ -0,0 +1,40 @@ + + * + * For the full copyright and license information, please view the LICENSE + * file that was distributed with this source code. + */ + +namespace Symfony\Bridge\Monolog\Tests\Handler; + +use PHPUnit\Framework\TestCase; +use Symfony\Bridge\Monolog\Handler\ChromePhpHandler; +use Symfony\Component\HttpFoundation\Request; +use Symfony\Component\HttpFoundation\Response; +use Symfony\Component\HttpKernel\Event\ResponseEvent; +use Symfony\Component\HttpKernel\HttpKernelInterface; + +class ChromePhpHandlerTest extends TestCase +{ + public function testOnKernelResponseShouldNotTriggerDeprecation() + { + $request = Request::create('/'); + $request->headers->remove('User-Agent'); + + $response = new Response('foo'); + $event = new ResponseEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MAIN_REQUEST, $response); + + $error = null; + set_error_handler(function ($type, $message) use (&$error) { $error = $message; }, \E_DEPRECATED); + + $listener = new ChromePhpHandler(); + $listener->onKernelResponse($event); + restore_error_handler(); + + $this->assertNull($error); + } +}