-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Serializer] Fix deserializing XML Attributes into string properties #58488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serializer] Fix deserializing XML Attributes into string properties #58488
Conversation
@dunglas can someone take a look at this? |
@dunglas what should be done about that AppVeyor? |
You can rebase, AppVeyor is gone, we moved to GithubActions even for windows tests |
Ugh wrong button 😑 Need to rebase manually tomorrow |
40bf017
to
7825527
Compare
Some HttpClient problems, but that shouldn't be related to my PR? |
@OskarStark what should I do about the failed Unit Tests? These look unrelated? |
7825527
to
a5ad19e
Compare
a5ad19e
to
67e2997
Compare
Can someone check the failed tests?
tried to rebase on a previous commit |
9e9007b
to
9a7183e
Compare
@nicolas-grekas there all tests are green too (except the Semaphore) |
Thanks for the ping. Looking at the code, I'm wondering if what you want isn't mean to be achieve by using the TYPE_CAST_ATTRIBUTES context option instead of changing anything in the code. |
Given the discussion in #58479, I think this should be considered as an improvement, so for 7.3 |
9a7183e
to
8032ef8
Compare
@nicolas-grekas there are some unrelated problems with but only for PHP 8.5, i try to pinpoint when it broke |
5933418
to
52a3832
Compare
Thank you @Hanmac. |
For XML Attributes that are turned into numerics by the XMLEncoder,
but the Property wanted different type (like String), convert them back.
I also added a TestCase