Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 7.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

I've also encountered this issue, and use a similar fix locally.

As @ehoutsma says, the problem is simply that $unacks is modified within the loop, messing up the iteration:

foreach ($unacks as $batchHandler) {
    ...
    try {
        ...
        unset($unacks[$batchHandler], $batchHandler); // <<-- $unacks modified while being iterated
    } catch (\Throwable $e) {
        ...
    }
}

Working example:

$handler1 = new stdClass();
$handler1->val = 1;

$handler2 = new stdClass();
$handler2->val = 2;

$unacks = new SplObjectStorage();
$unacks->attach($handler1);
$unacks->attach($handler2);

foreach ($unacks as $handler) {
    var_dump($handler);
    unset($unacks[$handler]);
}

Results in only one handler being processed:

object(stdClass)#1 (1) {
  ["val"]=>
  int(1)
}

I understand this issue doesn't occur with a lot of users. Leaving this issue unsolved, makes the use of batchhandling with multiple batchhandlers on the same queue unreliable.

@nicolas-grekas, Is it possible to merge this issue, since this is an issue that is still available even in version 7 of symfony?