Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Form] do not override the final runTest() method #58357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2024
Merged

[Form] do not override the final runTest() method #58357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions 18 src/Symfony/Component/Form/Test/FormPerformanceTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,19 +25,25 @@ abstract class FormPerformanceTestCase extends FormIntegrationTestCase
{
use VersionAwareTest;

private float $startTime;
protected int $maxRunningTime = 0;

protected function runTest(): mixed
protected function setUp(): void
{
$s = microtime(true);
$result = parent::runTest();
$time = microtime(true) - $s;
parent::setUp();

$this->startTime = microtime(true);
}

protected function assertPostConditions(): void
{
parent::assertPostConditions();

$time = microtime(true) - $this->startTime;

if (0 != $this->maxRunningTime && $time > $this->maxRunningTime) {
$this->fail(\sprintf('expected running time: <= %s but was: %s', $this->maxRunningTime, $time));
nicolas-grekas marked this conversation as resolved.
Show resolved Hide resolved
}

return $result;
}

/**
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.