Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[SecurityBundle] use firewall-specific user checkers when manually logging in users #57748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 17, 2024

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #57706
License MIT

@chalasr
Copy link
Member

chalasr commented Jul 18, 2024

Supersedes #54287 I think.

@chalasr
Copy link
Member

chalasr commented Jul 22, 2024

Thank you @xabbuh.

@chalasr chalasr merged commit 9eb3fbb into symfony:6.4 Jul 22, 2024
9 of 10 checks passed
@xabbuh xabbuh deleted the issue-57706 branch July 22, 2024 13:18
This was referenced Jul 26, 2024
@faizanakram99
Copy link
Contributor

@xabbuh this is a breaking change, earlier user checkers were not called for programmatic logins, now they're.

This has been working like this for a number of years and now the behaviour changed.

@chalasr
Copy link
Member

chalasr commented Jul 29, 2024

@faizanakram99 every bugfix breaks code that adapted itself to work with the bug. Defining a custom user checker implies that it replaces the default one but in this case the custom one was ignored, that is a bug.

@94noni
Copy link
Contributor

94noni commented Aug 7, 2024

just to comment that this properly addresses my original issue, calling the login user checker accordingly, thx @xabbuh and @chalasr

@faizanakram99 sad to hear that this break yours, can you detail your workflow of "security check" ? perhaps there is something different that may be done to satisfy both worlds

@faizanakram99
Copy link
Contributor

@94noni We were relying on the behaviour which was changed here and our tests broke all of sudden after upgrade, took me a while to figure this out. We adjusted it already with the new changes, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.