review changes

add r to handleR
symfony · eltharin · Jul 11, 2024 · Jul 26, 2024 · Aug 7, 2024 · Aug 8, 2024
commit 588566a4b5d49c9bbf4b6d23dac65143b5bf7e86
@@ -19,7 +19,7 @@
 use Symfony\Component\Config\Definition\Exception\InvalidConfigurationException;
 use Symfony\Component\Security\Http\EntryPoint\AuthenticationEntryPointInterface;
 use Symfony\Component\Security\Http\Session\SessionAuthenticationStrategy;
-use Symfony\Component\Security\Http\Authorization\SameAsNotFullFledgedHandle;
+use Symfony\Component\Security\Http\Authorization\SameAsNotFullFledgedHandler;

 /**
 * SecurityExtension configuration structure.
@@ -220,7 +220,7 @@ private function addFirewallsSection(ArrayNodeDefinition $rootNode, array $facto
                    ->ifTrue(fn ($v): bool => $v == 'original')
                        ->then(fn ($v) => null)
                    ->ifTrue(fn ($v): bool => $v == 'same')
-                        ->then(fn ($v) => SameAsNotFullFledgedHandle::class)
+                        ->then(fn ($v) => SameAsNotFullFledgedHandler::class)
                    ->end()
                ->end()
            ->arrayNode('logout')

@@ -45,7 +45,7 @@
 use Symfony\Component\Security\Core\User\MissingUserProvider;
 use Symfony\Component\Security\Core\Validator\Constraints\UserPasswordValidator;
 use Symfony\Component\Security\Http\Authentication\AuthenticationUtils;
-use Symfony\Component\Security\Http\Authorization\SameAsNotFullFledgedHandle;
+use Symfony\Component\Security\Http\Authorization\SameAsNotFullFledgedHandler;
 use Symfony\Component\Security\Http\Controller\SecurityTokenValueResolver;
 use Symfony\Component\Security\Http\Controller\UserValueResolver;
 use Symfony\Component\Security\Http\EventListener\IsGrantedAttributeListener;
@@ -325,6 +325,6 @@
            ->parent('cache.system')
            ->tag('cache.pool')

-        ->set('security.same_as_not_full_fledged_handle', SameAsNotFullFledgedHandle::class)
+        ->set('security.same_as_not_full_fledged_handle', SameAsNotFullFledgedHandler::class)
    ;
 };
diff --git a/...horization/SameAsNotFullFledgedHandle.php → ...orization/SameAsNotFullFledgedHandler.php b/...horization/SameAsNotFullFledgedHandle.php → ...orization/SameAsNotFullFledgedHandler.php
@@ -19,13 +19,13 @@
 use Symfony\Component\Security\Core\Exception\AccessDeniedException;

 /**
- * This is a basic NotFullFledgedHandle
+ * This is a basic NotFullFledgedHandler
 * If IS_AUTHENTICATED_FULLY is in access denied Exception Attrribute, behavior will be as before,
 * Otherwise The original AccessDeniedException is throw
 *
 * @author Roman JOLY <eltharin18@outlook.fr>
 */
-class SameAsNotFullFledgedHandle implements NotFullFledgedHandlerInterface
+class SameAsNotFullFledgedHandler implements NotFullFledgedHandlerInterface
 {
    public function handle(Request $request, AccessDeniedException $accessDeniedException, AuthenticationTrustResolverInterface $trustResolver, ?TokenInterface $token, callable $reauthenticateResponse): ?Response
    {

@@ -27,7 +27,7 @@
 use Symfony\Component\Security\Core\Exception\LogoutException;
 use Symfony\Component\Security\Http\Authorization\AccessDeniedHandlerInterface;
 use Symfony\Component\Security\Http\Authorization\NotFullFledgedHandlerInterface;
-use Symfony\Component\Security\Http\Authorization\SameAsNotFullFledgedHandle;
+use Symfony\Component\Security\Http\Authorization\SameAsNotFullFledgedHandler;
 use Symfony\Component\Security\Http\EntryPoint\AuthenticationEntryPointInterface;
 use Symfony\Component\Security\Http\Firewall\ExceptionListener;
 use Symfony\Component\Security\Http\HttpUtils;
@@ -267,7 +267,7 @@ private function createEvent(\Exception $exception, $kernel = null)
        return new ExceptionEvent($kernel, Request::create('/'), HttpKernelInterface::MAIN_REQUEST, $exception);
    }

-    private function createExceptionListener(?TokenStorageInterface $tokenStorage = null, ?AuthenticationTrustResolverInterface $trustResolver = null, ?HttpUtils $httpUtils = null, ?AuthenticationEntryPointInterface $authenticationEntryPoint = null, $errorPage = null, ?AccessDeniedHandlerInterface $accessDeniedHandler = null, ?NotFullFledgedHandlerInterface $notFullFledgedHandle = null)
+    private function createExceptionListener(?TokenStorageInterface $tokenStorage = null, ?AuthenticationTrustResolverInterface $trustResolver = null, ?HttpUtils $httpUtils = null, ?AuthenticationEntryPointInterface $authenticationEntryPoint = null, $errorPage = null, ?AccessDeniedHandlerInterface $accessDeniedHandler = null, ?NotFullFledgedHandlerInterface $notFullFledgedHandler = null)
    {
        return new ExceptionListener(
            $tokenStorage ?? $this->createMock(TokenStorageInterface::class),
@@ -279,15 +279,15 @@ private function createExceptionListener(?TokenStorageInterface $tokenStorage =
            $accessDeniedHandler,
            null,
            false,
-            $notFullFledgedHandle,
+            $notFullFledgedHandler,
        );
    }

    private function createNotFullFledgedHandler(?Response $response = null)
    {
-        $entryPoint = $this->createMock(NotFullFledgedHandlerInterface::class);
-        $entryPoint->method('handle')->willReturn($response);
+        $handler = $this->createMock(NotFullFledgedHandlerInterface::class);
+        $handler->method('handle')->willReturn($response);

-        return $entryPoint;
+        return $handler;
    }
 }
-Original file line number
+Diff line change
@@ -19,13 +19,13 @@
     use Symfony\Component\Security\Core\Exception\AccessDeniedException;
     /**
-     * This is a basic NotFullFledgedHandle
+     * This is a basic NotFullFledgedHandler
      * If IS_AUTHENTICATED_FULLY is in access denied Exception Attrribute, behavior will be as before,
                   eltharin marked this conversation as resolved.
              

          
            Show resolved
            Hide resolved
        

                
  
            
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.
      * Otherwise The original AccessDeniedException is throw
      *
      * @author Roman JOLY <eltharin18@outlook.fr>
      */
-    class SameAsNotFullFledgedHandle implements NotFullFledgedHandlerInterface
+    class SameAsNotFullFledgedHandler implements NotFullFledgedHandlerInterface
                   eltharin marked this conversation as resolved.
              

          
            Show resolved
            Hide resolved
        

                
  
            
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.
     {
         public function handle(Request $request, AccessDeniedException $accessDeniedException, AuthenticationTrustResolverInterface $trustResolver, ?TokenInterface $token, callable $reauthenticateResponse): ?Response
         {
-          Expand Down