[Serializer] Raise correct exception in ArrayDenormalizer when called without a nested denormalizer
#57646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when it's called without a nested denormalizer
|
I wonder if adding the type without initialising it as |
|
Maybe. But correcting that mistake without a BC break is hard. I think we're good. 😓 |
ArrayDenormalizer when called without a nested denormalizer
mtarld
approved these changes
Jul 12, 2024
xabbuh
approved these changes
Jul 12, 2024
stof
approved these changes
Jul 12, 2024
|
Thank you Alexander. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
$denormalizerproperty is not nullable and will be uninitialized by default. Because of that, the check that makes sure that the ArrayDenormalizer is not used before setting a nested denormalizer will produce an obscure error instead of raising the proper exception.