Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[SecurityBundle] Remove unused memory users’ name attribute from the XSD#57578

Merged
nicolas-grekas merged 1 commit intosymfony:6.4symfony/symfony:6.4from
MatTheCat:xsd_in-memory_nameMatTheCat/symfony:xsd_in-memory_nameCopy head branch name to clipboard
Jun 28, 2024
Merged

[SecurityBundle] Remove unused memory users’ name attribute from the XSD#57578
nicolas-grekas merged 1 commit intosymfony:6.4symfony/symfony:6.4from
MatTheCat:xsd_in-memory_nameMatTheCat/symfony:xsd_in-memory_nameCopy head branch name to clipboard

Conversation

@MatTheCat
Copy link
Copy Markdown
Contributor

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix cdb8354
License MIT

#57520 has been reverted because

[The] change […] risks that someone receives errors on the next patch release if their XML config still makes use of the now removed attribute.

But nobody could use it since v6.0: as #41613 removed the BC layer, the config would crash.

Keeping name in the XSD for 6.4, 7.0 and 7.1 branches means people using these versions would have their IDE suggesting an attribute which would make their app crash.

@nicolas-grekas
Copy link
Copy Markdown
Member

Thank you @MatTheCat.

@nicolas-grekas nicolas-grekas merged commit bc9964b into symfony:6.4 Jun 28, 2024
@MatTheCat MatTheCat deleted the xsd_in-memory_name branch June 28, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.