Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[DependencyInjection] Fix ignore invalid_reference behavior param for the some services #57561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 5.4
Choose a base branch
Loading
from
+1 −1
Open

[DependencyInjection] Fix ignore invalid_reference behavior param for the some services #57561

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 2 src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1009,7 +1009,7 @@ private function addInlineReference(string $id, Definition $definition, string $
$name = $this->getNextVariableName();
$this->referenceVariables[$targetId] = new Variable($name);

$reference = ContainerInterface::EXCEPTION_ON_INVALID_REFERENCE >= $behavior ? new Reference($targetId, $behavior) : null;
$reference = ContainerInterface::EXCEPTION_ON_INVALID_REFERENCE !== $behavior ? new Reference($targetId, $behavior) : null;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps, there was just a typo here and the author meant $behavior >= ContainerInterface::EXCEPTION_ON_INVALID_REFERENCE.

The bug was hidden for a long time because it can only be reproduced for "synthetic" services like kernel and in specific cases. But the other services replaced by null on optimization step before

$code .= sprintf(" \$%s = %s;\n", $name, $this->getServiceCall($targetId, $reference));

if (!$hasSelfRef || !$forConstructor) {
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.