[PropertyInfo] Skip extractors that do not implement getType
#57363
[PropertyInfo] Skip extractors that do not implement
getType
- Loading branch information
commit 6b7f4dcc78ae42c59e8d84b2a4eb8739b87ed5a9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the Symfony package. | ||
| * | ||
| * (c) Fabien Potencier <fabien@symfony.com> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace Symfony\Component\PropertyInfo\Tests\Fixtures; | ||
|
|
||
| use Symfony\Component\PropertyInfo\Extractor\ConstructorArgumentTypeExtractorInterface; | ||
| use Symfony\Component\PropertyInfo\PropertyAccessExtractorInterface; | ||
| use Symfony\Component\PropertyInfo\PropertyDescriptionExtractorInterface; | ||
| use Symfony\Component\PropertyInfo\PropertyInitializableExtractorInterface; | ||
| use Symfony\Component\PropertyInfo\PropertyListExtractorInterface; | ||
| use Symfony\Component\PropertyInfo\PropertyTypeExtractorInterface; | ||
| use Symfony\Component\PropertyInfo\Type as LegacyType; | ||
| use Symfony\Component\TypeInfo\Type; | ||
|
|
||
| class DummyLegacyExtractor implements PropertyListExtractorInterface, PropertyDescriptionExtractorInterface, PropertyTypeExtractorInterface, PropertyAccessExtractorInterface, PropertyInitializableExtractorInterface, ConstructorArgumentTypeExtractorInterface | ||
| { | ||
| public function getShortDescription($class, $property, array $context = []): ?string | ||
| { | ||
| return 'short'; | ||
| } | ||
|
|
||
| public function getLongDescription($class, $property, array $context = []): ?string | ||
| { | ||
| return 'long'; | ||
| } | ||
|
|
||
| public function getTypes($class, $property, array $context = []): ?array | ||
| { | ||
| return [new LegacyType(LegacyType::BUILTIN_TYPE_INT)]; | ||
| } | ||
|
|
||
| public function getTypesFromConstructor(string $class, string $property): ?array | ||
| { | ||
| return [new LegacyType(LegacyType::BUILTIN_TYPE_STRING)]; | ||
| } | ||
|
|
||
| public function getTypeFromConstructor(string $class, string $property): ?Type | ||
| { | ||
| return Type::string(); | ||
| } | ||
|
|
||
| public function isReadable($class, $property, array $context = []): ?bool | ||
| { | ||
| return true; | ||
| } | ||
|
|
||
| public function isWritable($class, $property, array $context = []): ?bool | ||
| { | ||
| return true; | ||
| } | ||
|
|
||
| public function getProperties($class, array $context = []): ?array | ||
| { | ||
| return ['a', 'b']; | ||
| } | ||
|
|
||
| public function isInitializable(string $class, string $property, array $context = []): ?bool | ||
| { | ||
| return true; | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not look like the right solution to me as it means that a formerly used extractor will now no longer be used leading to a (potentially) different result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I completely agree. I tried to put a message somewhere several times, but I was undecided and thought to have the PR rolling to have more feedback / ideas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I thought about strictly checking for
getTypeand have it default togetTypesand it would work for return values that have only 1 Type in the return array ofgetTypes. I think this change was done before: #54694. Most of the code in property-info thinks BIGINT is string and not this dual type scenario.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see #57459 for another attempt