Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[DependencyInjection] Fix regression in ordering service locators by priority #57345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 28, 2024
Merged

[DependencyInjection] Fix regression in ordering service locators by priority #57345

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0a7477d
Test convert CompletionInput into string
seriquynh Jun 28, 2024
c3bf9a6
[Filesystem][Mime] Fix transient tests
nicolas-grekas Jun 28, 2024
7beff57
minor #57570 [Console] Test convert CompletionInput into string (seri…
nicolas-grekas Jun 28, 2024
fd32ec5
minor #57575 [Filesystem][Mime] Fix transient tests (nicolas-grekas)
nicolas-grekas Jun 28, 2024
68eaede
Merge branch '5.4' into 6.4
nicolas-grekas Jun 28, 2024
b6ec960
Merge branch '6.4' into 7.0
nicolas-grekas Jun 28, 2024
d4b812c
Allow service locators to be ordered by priority.
longwave Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Test convert CompletionInput into string
  • Loading branch information
@seriquynh
seriquynh committed Jun 28, 2024
commit 0a7477d7540c7d1f954b36d65d8a9c85eee30df6
2 changes: 1 addition & 1 deletion 2 src/Symfony/Component/Console/Completion/CompletionInput.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public static function fromString(string $inputStr, int $currentIndex): self
* Create an input based on an COMP_WORDS token list.
*
* @param string[] $tokens the set of split tokens (e.g. COMP_WORDS or argv)
* @param $currentIndex the index of the cursor (e.g. COMP_CWORD)
* @param int $currentIndex the index of the cursor (e.g. COMP_CWORD)
*/
public static function fromTokens(array $tokens, int $currentIndex): self
{
Expand Down
15 changes: 15 additions & 0 deletions 15 src/Symfony/Component/Console/Tests/Completion/CompletionInputTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,4 +133,19 @@ public static function provideFromStringData()
yield ['bin/console cache:clear "multi word string"', ['bin/console', 'cache:clear', '"multi word string"']];
yield ['bin/console cache:clear \'multi word string\'', ['bin/console', 'cache:clear', '\'multi word string\'']];
}

public function testToString()
{
$input = CompletionInput::fromTokens(['foo', 'bar', 'baz'], 0);
$this->assertSame('foo| bar baz', (string) $input);

$input = CompletionInput::fromTokens(['foo', 'bar', 'baz'], 1);
$this->assertSame('foo bar| baz', (string) $input);

$input = CompletionInput::fromTokens(['foo', 'bar', 'baz'], 2);
$this->assertSame('foo bar baz|', (string) $input);

$input = CompletionInput::fromTokens(['foo', 'bar', 'baz'], 11);
$this->assertSame('foo bar baz |', (string) $input);
}
}
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.