Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[DoctrineBridge] Undeprecate DoctrineExtractor::getTypes() #56848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2024

Conversation

derrabus
Copy link
Member

Q A
Branch? 7.1
Bug fix? yes
New feature? no
Deprecations? no
Issues N/A
License MIT

The deprecation of the PropertyTypeExtractorInterface::getTypes() method was taken back in #54789. As long as the method exists on the interface, we cannot remove any implementations. Thus, I'm undeprecating the implementation in DoctrineExtractor as well.

@derrabus derrabus requested a review from dunglas as a code owner May 21, 2024 17:08
@carsonbot carsonbot changed the title Undeprecate DoctrineExtractor::getTypes() [DoctrineBridge] Undeprecate DoctrineExtractor::getTypes() May 21, 2024
@carsonbot carsonbot added this to the 7.1 milestone May 21, 2024
@derrabus derrabus merged commit 9d3932a into symfony:7.1 May 21, 2024
3 of 10 checks passed
@fabpot fabpot mentioned this pull request May 31, 2024
@derrabus derrabus deleted the bugfix/undeprecate-get-types branch December 7, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.