Create CONTRIBUTING.md file for auto-linking in PR's #5533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jmikola won the race |
| Bug fix: [yes|no] | ||
| Feature addition: [yes|no] | ||
| Backwards compatibility break: [yes|no] | ||
| Symfony2 tests pass: [yes|no] |
There was a problem hiding this comment.
I think this line should be dropped as PRs are tested automatically by Travis anyway, and the description is likely to describe only the state for the initial submission whereas Travis will update its status
|
and this should be updated according to the discussion on the dev mailing-list |
|
Instead of duplicating the information, I would just linked to the documentation. |
|
I reduced the file to the "Contributing" block from the readme. |
|
+1 |
fabpot
added a commit
that referenced
this pull request
Sep 17, 2012
Commits ------- 71d8148 Create CONTRIBUTING.md file for auto-linking in PR's Discussion ---------- Create CONTRIBUTING.md file for auto-linking in PR's See: https://github.com/blog/1184-contributing-guidelines --------------------------------------------------------------------------- by kbond at 2012-09-17T17:35:26Z @jmikola won the race --------------------------------------------------------------------------- by stof at 2012-09-17T17:37:35Z and this should be updated according to the discussion on the dev mailing-list --------------------------------------------------------------------------- by fabpot at 2012-09-17T17:42:28Z Instead of duplicating the information, I would just linked to the documentation. --------------------------------------------------------------------------- by jmikola at 2012-09-17T18:42:29Z I reduced the file to the "Contributing" block from the readme. --------------------------------------------------------------------------- by lsmith77 at 2012-09-17T19:36:36Z +1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://github.com/blog/1184-contributing-guidelines