Fix various warnings across components test suite #54824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
May 2, 2024
fabpot
approved these changes
May 4, 2024
|
Thank you @alexandre-daubois. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found out with @xabbuh that some warnings are "hidden" in the test suite of 5.4. Indeed, a risky test was raised in upper branches (starting from 6.4). However, this test was not marked as risky in the 5.4 branch. The reproducer is straightforward:
vendor/bin/phpunit src/Symfony/Component/Serializermarked the test as risky../phpunit src/Symfony/Component/Serializerdid not mark the test as risky.I went through components and bundle and executed PHPUnit to fix various warnings and deprecations hidden in the 5.4 CI. We don't know yet why 5.4 behaves this way. In the meantime, here are a few fixes of deprecated behaviors I found.