Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[HttpKernel] Support variadic with #[MapRequestPayload] #54817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 7.3
Choose a base branch
Loading
from
Open

[HttpKernel] Support variadic with #[MapRequestPayload] #54817

wants to merge 1 commit into from

Conversation

DjordyKoert
Copy link
Contributor

@DjordyKoert DjordyKoert commented May 2, 2024 •
edited by nicolas-grekas
Loading

Q A
Branch? 7.2
Bug fix? no
New feature? yes
Deprecations? no
Issues -
License MIT

Adds support for variadic arguments in combination with #[MapRequestPayload].

Example request

Content-Type: application/json
[
    {"price": 50},
    {"price": 23}
]

Example controller usage

class MyController
{
    public function __invoke(
        #[MapRequestPayload] Price ...$prices,
    ): Response {
        // do something with $prices -> array<Price>
    }
}

This PR also fixes a bug introduced in #49978 where using #[MapUploadedFile] with a variadic argument causes a TypeError:

class MyController
{
    public function __invoke(
        #[MapUploadedFile] UploadedFile ...$documents,
    ): Response {
    }
}
Argument #1 must be of type Symfony\\Component\\HttpFoundation\\File\\UploadedFile, array given

@carsonbot carsonbot added this to the 7.1 milestone May 2, 2024
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@DjordyKoert DjordyKoert force-pushed the map-request-payload-variadic branch from c08c101 to fc7b7c8 Compare May 2, 2024 12:38
@xabbuh xabbuh modified the milestones: 7.1, 7.2 May 2, 2024
@DjordyKoert DjordyKoert mentioned this pull request May 13, 2024
Closed
@nicolas-grekas nicolas-grekas modified the milestones: 7.2, 7.1 May 16, 2024
@fabpot fabpot modified the milestones: 7.2, 7.3 Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature HttpKernel Status: Needs Review
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.
5 participants
@DjordyKoert @carsonbot @fabpot @nicolas-grekas @xabbuh
Morty Proxy This is a proxified and sanitized view of the page, visit original site.