Fix tests, remove void return type in test

symfony · flkasper · May 1, 2024 · May 1, 2024 · May 1, 2024 · May 4, 2024
commit d67fa0ca80e3d73e7feb0ddb5eb0a684433ce1db
@@ -1303,7 +1303,7 @@ public function testAddingAlreadySetDefinitionElementData($def)
    public static function getAddingAlreadySetDefinitionElementData(): array
    {
        return [
-            [new InputArgument('command', InputArgument::REQUIRED)],
+            [new InputArgument('command', InputArgument::REQUIRED, 'The command to execute')],
            [new InputOption('quiet', '', InputOption::VALUE_NONE)],
            [new InputOption('query', 'q', InputOption::VALUE_NONE)],
        ];

@@ -316,7 +316,7 @@ public static function provideInvalidInput(): array
            ],
            [
                ['cli.php', 'acme:foo', 'bar'],
-                new InputDefinition([new InputArgument('command', InputArgument::REQUIRED)]),
+                new InputDefinition([new InputArgument('command', InputArgument::REQUIRED, 'The command to execute')]),
                'No arguments expected for "acme:foo" command, got "bar"',
            ],
            [

@@ -27,7 +27,7 @@ public function testConstructor()
        $this->assertEquals('foo', $argument->getName(), '__construct() takes a name as its first argument');
    }

-    public function testReservedArgumentName(): void
+    public function testReservedArgumentName()
    {
        self::expectException(InvalidArgumentException::class);
        self::expectExceptionMessage('Reserved keyword "command" was used as argument name.');

@@ -16,6 +16,7 @@
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Helper\HelperSet;
 use Symfony\Component\Console\Helper\QuestionHelper;
+use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Output\Output;
 use Symfony\Component\Console\Question\ChoiceQuestion;
 use Symfony\Component\Console\Question\Question;
@@ -30,7 +31,7 @@ class CommandTesterTest extends TestCase
    protected function setUp(): void
    {
        $this->command = new Command('foo');
-        $this->command->addArgument('command');
+        $this->command->addArgument('command', InputArgument::REQUIRED, 'The command to execute');
        $this->command->addArgument('foo');
        $this->command->setCode(function ($input, $output) { $output->writeln('foo'); });

@@ -231,7 +232,7 @@ public function testSymfonyStyleCommandWithInputs()
    public function testErrorOutput()
    {
        $command = new Command('foo');
-        $command->addArgument('command');
+        $command->addArgument('command', InputArgument::REQUIRED, 'The command to execute');
        $command->addArgument('foo');
        $command->setCode(function ($input, $output) {
            $output->getErrorOutput()->write('foo');