[Serializer] fix typo in AbstractNormalizerContextBuilder::withDefaultContructorArguments() #54643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Apr 18, 2024
|
Good catch, thanks @javaDeveloperKid. |
1 similar comment
|
Good catch, thanks @javaDeveloperKid. |
|
What about adding the method on 6.4 (without any deprecation yet?) so that ppl can start writing without typo right away? |
|
No contraindications from my side. Do you need another PR or will you cherry pick the new method on your own? |
|
A new PR please |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 23, 2024
…ultConstructorArguments()`method (javaDeveloperKid) This PR was merged into the 6.4 branch. Discussion ---------- [Serializer] Add `AbstractNormalizerContextBuilder::defaultConstructorArguments()`method | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Closes #54616 | License | MIT cherry-picked from #54643 with deprecation line removed. Commits ------- 19f91b0 [Serializer] Add AbstractNormalizerContextBuilder::defaultConstructorArguments()
nicolas-grekas
added a commit
that referenced
this pull request
May 17, 2024
…y (xabbuh) This PR was merged into the 7.1 branch. Discussion ---------- [Serializer] add missing deprecation contracts dependency | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT required since #54643 Commits ------- a912c49 add missing deprecation contracts dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a bug in the meaning of a bug so no need to fix this on 6.4. However a deprecation is needed.