[HttpFoundation] Set content-type header in RedirectResponse #54506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Apr 6, 2024
So i target 5.4 ? |
xabbuh
approved these changes
Apr 6, 2024
|
🤦 sorry guys for the notifications .... @xabbuh @nicolas-grekas if you can target 5.4 ... or i think i will make more mess.... |
dunglas
approved these changes
Apr 6, 2024
src/Symfony/Component/HttpFoundation/Tests/RedirectResponseTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpFoundation/Tests/RedirectResponseTest.php
Outdated
Show resolved
Hide resolved
chalasr
approved these changes
Apr 6, 2024
eccd932 to
954f1af
Compare
|
Thank you @smnandre. |
This was referenced Apr 29, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RedirectResponse has no content-type set, leading to the response using the "current" one (see issue #54434)
As
setTargetUrlset response body with HTML/UTF-8 content, it seems fair to add the matching header at this moment.(not sure if really a bug or not so i'm targetting 7.1 for now)