Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Console] Add of hidden and deprecation option flags #54439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: 7.4
Choose a base branch
Loading
from
+817 −64
Open

[Console] Add of hidden and deprecation option flags #54439

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
2cf5da9
[Console] Add of hidden and deprecation option flags
flkasper Mar 25, 2024
d203a4e
Fix code style
flkasper Mar 29, 2024
4d86a42
Change style of deprecated option to inline formatting
flkasper Mar 31, 2024
69b4bf8
[Console] Change color of deprecated option to gray
flkasper Apr 6, 2024
e2d3f12
[Console] Fixed test after color change
flkasper Apr 6, 2024
ece8b7a
[Console] Revert unrelated (style) changes
flkasper Apr 8, 2024
a08e4d5
[Console] Apply suggestion changes
flkasper Apr 8, 2024
02f0e0e
[Console] Fixed name of method
flkasper Apr 9, 2024
d4be218
[Console] Revert unrelated (style) changes
flkasper Apr 11, 2024
54baa40
[Console] Applied change suggestion in Command::writeDeprecationMessages
flkasper Apr 11, 2024
9a9ab17
[Console] Added suggested description prefix to deprecated options in…
flkasper Apr 11, 2024
cda876f
[Console] Apply suggestion & fixed coding standard of changes
flkasper Apr 14, 2024
c615abe
Apply suggestions from code review
flkasper Aug 26, 2024
6602bb4
Cleanup after rebase
flkasper Sep 7, 2024
05ad7d4
Apply cs patch
flkasper Sep 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[Console] Added suggested description prefix to deprecated options in… 
… TextDescriptor.php
  • Loading branch information
@flkasper
flkasper committed Sep 7, 2024
commit 9a9ab172f2fb95579293667a9d78287b3b64517b
8 changes: 6 additions & 2 deletions 8 src/Symfony/Component/Console/Descriptor/TextDescriptor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,15 @@ protected function describeInputOption(InputOption $option, array $options = [])

$spacingWidth = $totalWidth - Helper::width($synopsis);

$synopsis = \sprintf('<%1$s>%2$s</%1$s>', $option->isDeprecated() ? 'fg=gray;' : 'info', $synopsis);

$description = trim(($option->isDeprecated() ? '[deprecated] ' : '') . $option->getDescription());

$this->writeText(\sprintf(' %s %s%s%s%s',
\sprintf('<%1$s>%2$s</%1$s>', $option->isDeprecated() ? 'fg=gray;' : 'info', $synopsis),
$synopsis,
str_repeat(' ', $spacingWidth),
// + 4 = 2 spaces before <info>, 2 spaces after </info>
preg_replace('/\s*[\r\n]\s*/', "\n".str_repeat(' ', $totalWidth + 4), $option->getDescription()),
preg_replace('/\s*[\r\n]\s*/', "\n".str_repeat(' ', $totalWidth + 4), $description),
$default,
$option->isArray() ? '<comment> (multiple values allowed)</comment>' : ''
), $options);
Expand Down
2 changes: 1 addition & 1 deletion 2 src/Symfony/Component/Console/Tests/Fixtures/command_5.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
descriptor:command5 [options]

<comment>Options:</comment>
<fg=gray;>-y, --deprecated_option</fg=gray;>
<fg=gray;>-y, --deprecated_option</fg=gray;> [deprecated]

<comment>Help:</comment>
command 5 help
2 changes: 1 addition & 1 deletion 2 src/Symfony/Component/Console/Tests/Fixtures/command_5_with_hidden_options.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
descriptor:command5 [options]

<comment>Options:</comment>
<fg=gray;>-y, --deprecated_option</fg=gray;>
<fg=gray;>-y, --deprecated_option</fg=gray;> [deprecated]
<info>-z, --hidden_option</info>

<comment>Help:</comment>
Expand Down
2 changes: 1 addition & 1 deletion 2 src/Symfony/Component/Console/Tests/Fixtures/input_option_deprecated.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<fg=gray;>-o, --option_name</fg=gray;> deprecated option description
<fg=gray;>-o, --option_name</fg=gray;> [deprecated] deprecated option description
Morty Proxy This is a proxified and sanitized view of the page, visit original site.