-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[DoctrineBridge] Fix LockStoreSchemaListener not working properly with iterable objects #54407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d6b4d84
Revert "[DoctrineBridge] Ignore invalid stores in `LockStoreSchemaLis…
barton-webwings adeae5a
[Lock] Add NullStore
barton-webwings a2d215a
[Lock] Add a case for the new NullStore to StoreFactory
barton-webwings e8c0279
[Lock] Add licence header to NullStore
barton-webwings File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[Lock] Add NullStore
- Loading branch information
commit adeae5ae948930f49eb87976e57a9ac836e7a0be
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
<?php | ||
|
||
namespace Symfony\Component\Lock\Store; | ||
|
||
use Symfony\Component\Lock\BlockingSharedLockStoreInterface; | ||
use Symfony\Component\Lock\Key; | ||
|
||
/** | ||
* NullStore is a PersistingStoreInterface implementation which discards all operations. | ||
* | ||
* @author Pavel Bartoň <barton@webwings.cz> | ||
*/ | ||
class NullStore implements BlockingSharedLockStoreInterface | ||
{ | ||
public function save(Key $key): void | ||
{ | ||
} | ||
|
||
public function saveRead(Key $key): void | ||
{ | ||
} | ||
|
||
public function waitAndSaveRead(Key $key): void | ||
{ | ||
} | ||
|
||
public function delete(Key $key): void | ||
{ | ||
} | ||
|
||
public function exists(Key $key): bool | ||
{ | ||
return false; | ||
} | ||
|
||
public function putOffExpiration(Key $key, float $ttl): void | ||
{ | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Introducing this class (as well as the changes to the
StoreFactory
) must be moved into a separate PR targeting the7.2
branch. That's a new feature.