[FrameworkBundle] Increase RequestValueResolver and SessionValueResolver priority
#54374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think |
RequestValueResolver priorityRequestValueResolver and SessionValueResolver priority
94noni
reviewed
Mar 24, 2024
…solver` priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RequestValueResolverandSessionValueResolverare simple and fast, so it may make sense to run them before theEntityValueResolver. That way arguments type-hinted withRequestorSessionwon’t have to wait for entity managers to be initialized and looped over. The linked issue says it can take 40–50ms; I wasn’t able to reproduce such numbers locally but it still seems worth it.