Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Update changed-translation-files step with native git diff command #54274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

arifszn
Copy link
Contributor

@arifszn arifszn commented Mar 13, 2024

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

Description

The Integration workflow currently relies on the marceloprado/has-changed-path action to detect changes in translation files. However, this action is still utilizing Node.js version 16. Consequently, warnings about the deprecation of Node.js 16 actions appear whenever the Integration workflow is executed.

image

This pull request proposes the removal of the marceloprado/has-changed-path action. Instead, it leverages the native git diff command, accessible through actions/checkout. This approach ensures smoother integration and avoids reliance on deprecated Node.js versions. Also, this PR gives a name to that step.

@nicolas-grekas
Copy link
Member

Thank you @arifszn.

@nicolas-grekas nicolas-grekas merged commit c9bce39 into symfony:5.4 Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.