Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[DoctrineBridge] Fix deprecation warning with ORM 3 when guessing field lengths #54271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2024
Merged

[DoctrineBridge] Fix deprecation warning with ORM 3 when guessing field lengths #54271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[DoctrineBridge] Fix deprecation warning with ORM 3 when guessing fie… 
…ld lengths
  • Loading branch information
@eltharin @fabpot
eltharin authored and fabpot committed Mar 17, 2024
commit 43d9c191145fe1fb1ac7e2cd1268e542ed0c7b1b
7 changes: 5 additions & 2 deletions 7 src/Symfony/Bridge/Doctrine/Form/DoctrineOrmTypeGuesser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

use Doctrine\DBAL\Types\Types;
use Doctrine\ORM\Mapping\ClassMetadataInfo;
use Doctrine\ORM\Mapping\FieldMapping;
use Doctrine\ORM\Mapping\JoinColumnMapping;
use Doctrine\ORM\Mapping\MappingException as LegacyMappingException;
use Doctrine\Persistence\ManagerRegistry;
Expand Down Expand Up @@ -141,8 +142,10 @@ public function guessMaxLength(string $class, string $property)
if ($ret && isset($ret[0]->fieldMappings[$property]) && !$ret[0]->hasAssociation($property)) {
$mapping = $ret[0]->getFieldMapping($property);

if (isset($mapping['length'])) {
return new ValueGuess($mapping['length'], Guess::HIGH_CONFIDENCE);
$length = $mapping instanceof FieldMapping ? $mapping->length : ($mapping['length'] ?? null);

if (null !== $length) {
return new ValueGuess($length, Guess::HIGH_CONFIDENCE);
}

if (\in_array($ret[0]->getTypeOfField($property), [Types::DECIMAL, Types::FLOAT])) {
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.