Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[TwigBridge] Use CPP #54244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2024
Merged

[TwigBridge] Use CPP #54244

merged 1 commit into from
Mar 12, 2024

Conversation

connorhu
Copy link
Contributor

Q A
Branch? 7.1
Bug fix? no
New feature? no
Deprecations? no
Issues N/A
License MIT

I can also help with this kind of thing. So here we are.

@connorhu connorhu requested review from lyrixx and xabbuh as code owners March 12, 2024 06:51
@carsonbot carsonbot added this to the 7.1 milestone Mar 12, 2024
@connorhu connorhu force-pushed the impr/use-cpp-twig-bridge branch from 2911699 to 0e9cc19 Compare March 12, 2024 06:55
derrabus
derrabus reviewed Mar 12, 2024
View reviewed changes
src/Symfony/Bridge/Twig/Extension/ProfilerExtension.php Outdated Show resolved Hide resolved
@nicolas-grekas nicolas-grekas force-pushed the impr/use-cpp-twig-bridge branch from e4e760f to d4f8f39 Compare March 12, 2024 12:09
@nicolas-grekas
Copy link
Member

Thank you @connorhu.

@nicolas-grekas nicolas-grekas merged commit d508d5f into symfony:7.1 Mar 12, 2024
@connorhu
Copy link
Contributor Author

Thank you @connorhu.

I wanted to wait for the tests to run and then squash. Thank you anyway!

@connorhu connorhu deleted the impr/use-cpp-twig-bridge branch March 12, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

@lyrixx lyrixx Awaiting requested review from lyrixx lyrixx is a code owner

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Status: Reviewed TwigBridge
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.
4 participants
@connorhu @nicolas-grekas @derrabus @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.