[Lock] Check the correct SQLSTATE error code for MySQL #54201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
edomato
commented
Mar 8, 2024
- Closes bug: [Lock] PDOStore checks for wrong error code in PDOException for MySQL #54091
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | Fix #54091 |
| License | MIT |
| @@ -337,7 +337,7 @@ private function isTableMissing(\PDOException $exception): bool | ||
| case 'sqlite' === $driver && str_contains($exception->getMessage(), 'no such table:'): | ||
| case 'oci' === $driver && 942 === $code: | ||
| case 'sqlsrv' === $driver && 208 === $code: | ||
| case 'mysql' === $driver && 1146 === $code: | ||
| case 'mysql' === $driver && '42S02' === $code: |
There was a problem hiding this comment.
I was wondering why we had this code and dbal is effectively doing something special to get that "1186".
Instead of this change, I'd suggest modifying L333 this way:
$code = $exception->errorInfo ? $exception->errorInfo[1] : $exception->getCode();
Note that the same code exists in src/Symfony/Component/Cache/Adapter/PdoAdapter.php
* Closes bug: symfony#54091 Signed-off-by: Ernesto Domato <edomato@gmail.com>
b7e1744 to
7318816
Compare
|
Thank you @edomato. |
This was referenced Apr 2, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.