Is there a way to test this?

I think I did add tests, do you have something more in mind?

Something must have blinded me 👀 Sorry!

I don't think so :)

I tested this fix but it doesn't work for me

I use PhpDocExtractor to be able to denormalize objects with properties like this:

class Form // Not a doctrine entity
{
    /**
     * @var Step[]
     */
    private array $steps;
}

class Step // Not a doctrine entity
{
}

However I still get the same error when I serialize this kind objects :

class FormOutput // Not a doctrine entity
{
    /**
     * @var IndicatorType                                    <--- A Doctrine entity
     */
    private IndicatorType $indicatorType;
}

User Notice: Undefined property: Proxies_CG_\App\Entity\IndicatorType::$lazyObjectState in /home/.../src/Serializer/PropertyAccessor.php on line 419

@alexandre-le-borgne Can you please open a new issue and provide a small example application that allows to reproduce your issue?

@xabbuh #54393

This change broke my tests. They work with 6.4.4 and not with 6.4.6.
I get the error Can\'t get a way to read the property "%s" in class "%s".'

I use magic getters in one of my entities like so:

    public function __get(string $arg)
    {
        if (preg_match('/custom_checkbox_(\d+)_entry(_other)?/', $arg, $matches)) {
            if (isset($matches[2])) {
                return $this->getCustomCheckboxEntryOther((int) $matches[1]);
            }

            return $this->getCustomCheckboxEntryForCheckbox((int) $matches[1]);
        }
        if (preg_match('/customCheckboxEntryValueByCheckboxId(\d+)/', $arg, $matches)) {
            return $this->getCustomCheckboxEntryValueByCheckboxId((int) $matches[1]);
        }
    }

my tests use liip/test-fixtures-bundle (if this matters).

@craigh you might have a broken implementation of __isset, please have a look and try to fix it.

@nicolas-grekas of course, you are correct 🎉 thank you for your keen insight and quick response!

This is a BC break, I'm now getting:

[NoSuchPropertyException]
Can't get a way to read the property "offerFallback" in class "App\Entity\Offer".

Even if I have this, to access dynamic properties stored in a json column:

public function __get(string $name): mixed
{
    if (property_exists(Offer::class, $name)) {
        return $this->$name;
    }
    return $this->getSetting($name) ?? null;
}

It's look like the magic getter is never called

@fmonts same as above: you likely have a broken implementation of __isset, please have a look and try to fix it.

@fmonts same as above: you likely have a broken implementation of __isset, please have a look and try to fix it.

I don't have any __isset(), I accept virtually any name, this would require me to add

public function __isset(string $name): bool
{
    return true;
}

to many entities...

That's why then. You relied on a specific behavior of PropertyAccess, which is broken in the generic case (eg the ?? operator should be broken with you objects, etc).

This seems to break access to properties in Laravel Eloquent models when the value is null. This is because __isset() returns false if the value is null and no actual property exists on the model. And if a model is not loaded from the database yet, it will have no properties. So it's impossible to check if it will be allowed.

I'm not sure if there is a 'standard' way to check for access there, because of the way ActiveRecord works (at least in Laravel). In Laravel it is always possible to set or get a property on the model..
Eg. when setting $model->name = 'Foo'; it will set $model->attributes['name'] (and perform additional actions when setting/getting) using the magic __get() and __set() methods. If an attribute is requested that does not exist, it will return null.

Hi all,

I faced an issue today trying to upgrade a SF 6.4 project regarding this point.

I have a Dto with a property _foo as an array.

public array $_foo = [];

I have also a magic getter on this Dto like that.

    public function __get(string $name)
    {
        if (isset($this->_foo[$name])) {
            return $this->_foo[$name];
        }

        throw new \Exception('Invalid property');
    }

Now with this PR, code break because of the $r = new \ReflectionProperty($class, $name); as obviously if I try to access a property name bar not existing in the Dto class, ReflexionProperty just throw an exception (it does not try to know if a magic method will allow to get this value).

PHP documentation said:

__get() is utilized for reading data from inaccessible (protected or private) or non-existing properties.

In regards of the php doc, I should be able to read this property using the magic method, so I'm confused with this "can't get a way to read the property" error.

Is this because I'm wrong with my understanding on how I'm allowed to work with magic getter, or because this fix is now too strict and can results in false error on some edge cases like mine ?

@u03c1 You also need to implement the __isset() method accordingly.

@u03c1 You also need to implement the __isset() method accordingly.

Well, I have seen this same answer 2 or 3 times on this thread before I post, but my brain didn't connect and search an isset in my __get(), not an __isset(). 🤦

Thanks again.