[AssetMapper] Throw exception in Javascript compiler when PCRE error #54113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91ed84e to
0384254
Compare
derrabus
reviewed
Feb 29, 2024
src/Symfony/Component/AssetMapper/Tests/Compiler/JavaScriptImportPathCompilerTest.php
Outdated
Show resolved
Hide resolved
derrabus
reviewed
Feb 29, 2024
src/Symfony/Component/AssetMapper/Tests/Compiler/JavaScriptImportPathCompilerTest.php
Show resolved
Hide resolved
derrabus
approved these changes
Feb 29, 2024
|
(AppVeyor failures unrelated) |
fabpot
approved these changes
Mar 4, 2024
0165854 to
2333b58
Compare
|
Thank you @smnandre. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preg_match_callbackcan return null when a PCRE error occured, leading there to a TypeError.Let's throw an exception and expose the error message.
(follows #54078 / complementary to #54079 )