[Security] Add retrieval of encompassing role names #53998
+39
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
c48453b to
f1cc872
Compare
f1cc872 to
a21bcee
Compare
The aim of this method is to provide a handy way of getting the roles that encompass (or are parent of) an array of roles. It is similar to the getReachableRoleNames from the same interface but instead of retrieving the children roles it retrieves the parent roles. A typical use case would be when we get a user role from a database and need to get all the roles that also have access to what this role can access.
a21bcee to
983742e
Compare
94noni
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this method is to provide a handy way of getting the roles that encompass (or are parent of) an array of roles.
It is similar to the
RoleHierarchyInterface::getReachableRoleNames(array $roles)but instead of retrieving the roles and children roles it retrieves the roles and parent roles.A typical use case would be when we get a user role from a database and need to get all the roles that also have access to whatever this role can access.
Also what do you guys think of renaming the existing
getReachableRoleNames(that retrieves the "children roles" of an array of roles) as well asgetEncompassingRoleNames(that retrieves the "parent roles" of an array of roles) togetParentRolesandgetChildrenRolesin order to better reflect their intention ?For the sake of this PR I tried to use a naming that is consistent with the existing
getReachableRoleNamesmethod.