Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix Inconsistent Exit Status in proc_get_status for PHP Versions Below 8.3 #53820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions 16 src/Symfony/Component/Process/Process.php
Original file line number Diff line number Diff line change
Expand Up @@ -1289,8 +1289,24 @@ protected function updateStatus(bool $blocking): void
}

$this->processInformation = proc_get_status($this->process);

$running = $this->processInformation['running'];

// In PHP < 8.3, "proc_get_status" only returns the correct exit status on the first call.
// Subsequent calls return -1 as the process is discarded. This workaround caches the first
// retrieved exit status for consistent results in later calls, mimicking PHP 8.3 behavior.
if (version_compare(\PHP_VERSION, '8.3.0', '<')) {
static $cachedExitCode = null;

if (null === $cachedExitCode && !$running && -1 !== $this->processInformation['exitcode']) {
$cachedExitCode = $this->processInformation['exitcode'];
}

if (null !== $cachedExitCode && !$running && -1 === $this->processInformation['exitcode']) {
$this->processInformation['exitcode'] = $cachedExitCode;
}
}

$this->readPipes($running && $blocking, '\\' !== \DIRECTORY_SEPARATOR || !$running);

if ($this->fallbackStatus && $this->isSigchildEnabled()) {
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.