Use Symfony "dark-mode"-responsive logo in README #53676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following symfony#53105 @javiereguiluz uploaded a Symfony "dynamic" logo, which color scheme depends on user preferences. Thus allowing the README's logo to look sharper and cleaner in dark mode (on Github.com, on PHPStorm, ...) ```diff <svg> <style> .symfony-logo-circle, .symfony-logo-letter { fill: #000; } .symfony-logo-circle-letters { fill: #fff; } + @media (prefers-color-scheme: dark) { + .symfony-logo-circle, .symfony-logo-letter { fill: #fff; } + .symfony-logo-circle-letters { fill: #000; } } </style> <!-- SVG code --> </svg> ```
cbb755d to
eae4ec9
Compare
|
Thank you @smnandre. |
|
In the official mobile app. Android with dark mode interface. |
|
@antonkomarev could you try on the 5.4 branch just to be sure ? |
|
On my iPhone: GitHub app
Safari
Both screenshots show the 5.4 branch, but it's the same on 7.1. |
weaverryan
added a commit
to symfony/ux
that referenced
this pull request
Jan 30, 2024
This PR was merged into the 2.x branch. Discussion ---------- [DX] Use dark-mode Symfony logo See symfony/symfony#53676 | Before | After | | - | - | |  |  | Commits ------- 7260c6b [DX] Use dark-mode Symfony logo
Just to be complete, could you show how it renders in light mode ? |
|
Certainly!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #53105 @javiereguiluz uploaded a Symfony "dynamic" logo, featuring a color scheme that adapts to user preferences.
This enhancement allows the README's logo to appear sharper and cleaner in dark mode (on Github.com, in PHPStorm, ...)
<svg> <style> + @media (prefers-color-scheme: dark) { + .symfony-logo-circle, .symfony-logo-letter { fill: #fff; } + .symfony-logo-circle-letters { fill: #000; } } </style> <!-- SVG code --> </svg>( Thank you again @javiereguiluz )