[HttpClient] Fix pausing responses before they start when using curl #53671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HypeMC
pushed a commit
to HypeMC/symfony
that referenced
this pull request
Jan 29, 2024
…t when using curl (nicolas-grekas) This PR was merged into the 5.4 branch. Discussion ---------- [HttpClient] Fix pausing responses before they start when using curl | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix symfony#53622 | License | MIT Curl doesn't support pausing responses before they started, that's why the call to `curl_multi_remove_handle` is needed. But the removed line breaks tracking responses that did start. Commits ------- c6c5303 [HttpClient] Fix pausing responses before they start when using curl
This was referenced Jan 30, 2024
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curl doesn't support pausing responses before they started, that's why the call to
curl_multi_remove_handleis needed. But the removed line breaks tracking responses that did start.