#48167 add fallbackCallbackAccessor to PropertyPathAccessor to suppor… #53589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "5.4". Cheers! Carsonbot |
added 2 commits
March 24, 2024 14:51
… support custom getter methods when submitting a form
ba46382 to
213f015
Compare
yceruto
requested changes
Apr 24, 2024
|
|
||
| public function __construct(?PropertyAccessorInterface $propertyAccessor = null) | ||
| { | ||
| $this->propertyAccessor = $propertyAccessor ?? PropertyAccess::createPropertyAccessor(); | ||
| $this->fallbackCallbackAccessorForCustomGetter = new CallbackAccessor(); |
There was a problem hiding this comment.
This could be simpler, but it's limited to falling back on CallbackAccessor only, when it could be any DataAccessorInterface adapter.
See #54723 for a more generic solution.
|
Thank you for starting this Conrad. Closing in favour of #54723. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t custom getter methods when submitting a form
Added a private
CallbackAccessorto thePropertyPathAccessorto have a 2nd look if there is a custom getter defined in the form config and use this as fallback..