[Messenger] [AmazonSqs] Allow async-aws/sqs version 2
#53524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
async-aws/sqs version 2
fc9a4d1 to
8bcfb99
Compare
|
Tests are fixed. appveyor failues are unrelated to this PR. |
derrabus
approved these changes
Jan 15, 2024
8bcfb99 to
ed784c8
Compare
|
Base branch changed to 5.4 |
2634947 to
3d8226a
Compare
xabbuh
approved these changes
Jan 15, 2024
stof
requested changes
Jan 15, 2024
There was a problem hiding this comment.
The dev requirement in the root composer.json should also be updated.
And once this is done, you will need to fix the integration-tests workflow which will break because the asyncaws/testing-sqs docker image only provides a fake implementation of the old protocol. You should migrate to localstack for the integration tests (as was done in async-aws itself)
3d8226a to
6e15f58
Compare
6e15f58 to
96f103a
Compare
|
@stof I updated the missing parts :-) |
nicolas-grekas
approved these changes
Jan 23, 2024
|
Thank you @smoench. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 23, 2024
…(smoench) This PR was merged into the 5.4 branch. Discussion ---------- [Messenger] [AmazonSqs] Allow `async-aws/sqs` version 2 | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Issues | - | License | MIT With this PR async-aws/sqs version 2 would be allowed to be installed. [With version 2 they are using the AWS JSON-1.0 protocol instead of the XML one](https://github.com/async-aws/sqs/blob/master/CHANGELOG.md#200). They declared this as a BC-Break as they switced the protocol from query to json, but no public method signatures have been changed. TODO - [x] Provide JSON stubs for tests Commits ------- 96f103a [Messenger][AmazonSqs] Allow async-aws/sqs version 2
nicolas-grekas
added a commit
that referenced
this pull request
Jan 23, 2024
* 6.3: minor #53524 [Messenger] [AmazonSqs] Allow `async-aws/sqs` version 2 (smoench) Fix bad merge List CS fix in .git-blame-ignore-revs Fix implicitly-required parameters List CS fix in .git-blame-ignore-revs Apply php-cs-fixer fix --rules nullable_type_declaration_for_default_null_value
nicolas-grekas
added a commit
that referenced
this pull request
Jan 23, 2024
* 6.4: Fix implicitly-required parameters minor #53524 [Messenger] [AmazonSqs] Allow `async-aws/sqs` version 2 (smoench) Fix bad merge List CS fix in .git-blame-ignore-revs Fix implicitly-required parameters List CS fix in .git-blame-ignore-revs Apply php-cs-fixer fix --rules nullable_type_declaration_for_default_null_value [Messenger][AmazonSqs] Allow async-aws/sqs version 2
nicolas-grekas
added a commit
that referenced
this pull request
Jan 23, 2024
* 7.0: List CS fix in .git-blame-ignore-revs Fix implicitly-required parameters minor #53524 [Messenger] [AmazonSqs] Allow `async-aws/sqs` version 2 (smoench) Fix bad merge List CS fix in .git-blame-ignore-revs Fix implicitly-required parameters List CS fix in .git-blame-ignore-revs Apply php-cs-fixer fix --rules nullable_type_declaration_for_default_null_value [Messenger][AmazonSqs] Allow async-aws/sqs version 2
nicolas-grekas
added a commit
that referenced
this pull request
Feb 14, 2024
This PR was merged into the 5.4 branch. Discussion ---------- [Messenger] Fix SQS visibility_timeout type | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Introduced in #53524 | License | MIT Getting an error after `composer update`: ``` Error thrown while running command "messenger:consume -- async". Message: "HTTP 400 returned for "https://sqs.eu-west-1.amazonaws.com/)". Code: SerializationException Message: STRING_VALUE can not be converted to an Integer Type: Detail: " ``` `async-aws/sqs` v2 is using JSON instead of `x-www-form-urlencoded` so now all of the sudden, types do matter. If you set `visibility_timeout` in the DSN, it will be sent as a string to SQS – so we need to cast it explicitly. Commits ------- 6683d4c Fix SQS visibility_timeout type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR async-aws/sqs version 2 would be allowed to be installed. With version 2 they are using the AWS JSON-1.0 protocol instead of the XML one. They declared this as a BC-Break as they switced the protocol from query to json, but no public method signatures have been changed.
TODO