Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Validator] Add PHPDoc to GroupSequence attribute class and properties #53428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 7.3
Choose a base branch
Loading
from

Conversation

kzorluoglu
Copy link

Q A
Branch? 7.1
Bug fix? no
New feature? no
Deprecations? no
Issues Fix #51920
License MIT

This pull request adds detailed PHPDoc comments to the GroupSequence class in the Symfony\Component\Validator\Constraints namespace. The added documentation includes a comprehensive class description and descriptive comments for each public property and the constructor.

These changes are in response to the issue #51920 and follow the same documentation style and standards as Symfony's existing components.

@carsonbot carsonbot added this to the 7.1 milestone Jan 4, 2024
@OskarStark OskarStark changed the title [Validator] Add PHPDoc to GroupSequence attribute class and properties #53424 [Validator] Add PHPDoc to GroupSequence attribute class and properties Jan 5, 2024
Comment on lines 68 to +69
*
* If a class has a group sequence attached, that sequence replaces the
* "Default" group. When validating that class in the "Default" group, the
* group sequence is used instead, but still the "Default" group should be
* cascaded to other objects.
* @var string|GroupSequence
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two lines should be deleted to make the fabbot happy.

@xabbuh xabbuh modified the milestones: 7.1, 7.2 May 15, 2024
@fabpot fabpot modified the milestones: 7.2, 7.3 Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve PHPDoc descriptions of Attribute classes and parameters
6 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.