[Validator] Add PHPDoc to Isbn attribute class and properties
#53424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Jan 4, 2024
OskarStark
reviewed
Jan 4, 2024
Isbn attribute class and properties
|
Please make fabbot happy, thanks |
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
|
This has been done in #52012 so this is a duplicate, sorry. |
|
Are you sure? It's listed here without PR anyway?
|
|
I checked, it was done before with a little less detail. I think this version is more detailed and understandable. it's your opinion. |
|
I think we're going to prefer short descriptions like done in #52012 Thanks for submitting anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds detailed PHPDoc comments to the Isbn class within the Symfony Validator component. These comments include comprehensive descriptions for the class itself, its constructor arguments, and public properties. This enhancement aims to improve the understanding and usability of the Isbn class, especially for developers new to the Symfony framework or this specific component.