From 0de35b09c7823dc2ed5fcb07a863093d3f4db621 Mon Sep 17 00:00:00 2001 From: llupa Date: Mon, 18 Dec 2023 18:00:38 +0100 Subject: [PATCH] Change ProxyCacheWarmer::warmUp signature --- UPGRADE-6.4.md | 1 + src/Symfony/Bridge/Doctrine/CHANGELOG.md | 1 + src/Symfony/Bridge/Doctrine/CacheWarmer/ProxyCacheWarmer.php | 5 +---- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/UPGRADE-6.4.md b/UPGRADE-6.4.md index 36b4ea046fc4c..65e26337ac4ef 100644 --- a/UPGRADE-6.4.md +++ b/UPGRADE-6.4.md @@ -96,6 +96,7 @@ DependencyInjection DoctrineBridge -------------- + * [BC Break] Add argument `$buildDir` to `ProxyCacheWarmer::warmUp()` * [BC Break] Add return type-hints to `EntityFactory` * Deprecate `DbalLogger`, use a middleware instead * Deprecate not constructing `DoctrineDataCollector` with an instance of `DebugDataHolder` diff --git a/src/Symfony/Bridge/Doctrine/CHANGELOG.md b/src/Symfony/Bridge/Doctrine/CHANGELOG.md index 1e56772bea675..867f9d42295ce 100644 --- a/src/Symfony/Bridge/Doctrine/CHANGELOG.md +++ b/src/Symfony/Bridge/Doctrine/CHANGELOG.md @@ -4,6 +4,7 @@ CHANGELOG 6.4 --- + * [BC BREAK] Add argument `$buildDir` to `ProxyCacheWarmer::warmUp()` * [BC BREAK] Add return type-hints to `EntityFactory` * Deprecate `DbalLogger`, use a middleware instead * Deprecate not constructing `DoctrineDataCollector` with an instance of `DebugDataHolder` diff --git a/src/Symfony/Bridge/Doctrine/CacheWarmer/ProxyCacheWarmer.php b/src/Symfony/Bridge/Doctrine/CacheWarmer/ProxyCacheWarmer.php index f0731c26b7941..e59f785b82d43 100644 --- a/src/Symfony/Bridge/Doctrine/CacheWarmer/ProxyCacheWarmer.php +++ b/src/Symfony/Bridge/Doctrine/CacheWarmer/ProxyCacheWarmer.php @@ -37,10 +37,7 @@ public function isOptional(): bool return false; } - /** - * @param string|null $buildDir - */ - public function warmUp(string $cacheDir /* , string $buildDir = null */): array + public function warmUp(string $cacheDir, string $buildDir = null): array { $files = []; foreach ($this->registry->getManagers() as $em) {