Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Workflow] Add getEnabledTransition() to TraceableWorkflow #52814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexandre-daubois
Copy link
Member

@alexandre-daubois alexandre-daubois commented Nov 30, 2023

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #52812
License MIT

I added an annotation to WorkflowInterface to not break BC. I think it could deserve an additional not implementing this method is deprecated since Symfony 7.1 while upmerging (I guess ?).

Added the tests while at it.

Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks 👍🏼

src/Symfony/Component/Workflow/WorkflowInterface.php Outdated Show resolved Hide resolved
@nicolas-grekas
Copy link
Member

Thank you @alexandre-daubois.

@nicolas-grekas nicolas-grekas merged commit 270e648 into symfony:6.4 Dec 1, 2023
@alexandre-daubois alexandre-daubois deleted the traceable-workflow-fix branch December 1, 2023 15:34
This was referenced Dec 1, 2023
fabpot added a commit that referenced this pull request Dec 8, 2023
…ion to WorkflowInterface (alexandre-daubois)

This PR was merged into the 7.1 branch.

Discussion
----------

[Workflow] Add `getEnabledTransition()` method annotation to WorkflowInterface

| Q             | A
| ------------- | ---
| Branch?       | 7.1
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | yes
| Issues        | -
| License       | MIT

Followup of #52814

Commits
-------

19abb99 [Workflow] Add `getEnabledTransition()` method annotation to WorkflowInterface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.