Fix legacy class palceholder definitions for static analysis #52798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
reviewed
Nov 29, 2023
There was a problem hiding this comment.
Some other moved classes are not extending the new class:
Symfony\Bundle\FrameworkBundle\Routing\AnnotatedRouteControllerLoaderSymfony\Component\HttpKernel\Debug\FileLinkFormatterSymfony\Component\Routing\Loader\AnnotationClassLoaderSymfony\Component\Routing\Loader\AnnotationDirectoryLoaderSymfony\Component\Routing\Loader\AnnotationFileLoaderSymfony\Component\Serializer\Mapping\Loader\AnnotationLoader
It may be necessary to do the same change on them.
Will do. |
GromNaN
approved these changes
Nov 29, 2023
53758ef to
0f230fe
Compare
|
Thank you @ausi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #50392 the
UriSignerclass was moved from HttpKernel to HttpFoundation. The empty definitionclass UriSigner {}causes many issues with static analysis tools like PHPStan.As this code is wrapped in an
if (false)changing it toclass UriSigner extends HttpFoundationUriSignershould not cause any behavior change while fixing most static analysis issues.