[DebugBundle] ignore a not-existing virtual request stack #52290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Oct 25, 2023
| Q | A |
|---|---|
| Branch? | 6.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | Fix #52280 |
| License | MIT |
| @@ -50,7 +50,7 @@ | ||
| service('debug.stopwatch')->ignoreOnInvalid(), | ||
| service('debug.file_link_formatter')->ignoreOnInvalid(), | ||
| param('kernel.charset'), | ||
| service('.virtual_request_stack'), | ||
| service('.virtual_request_stack')->ignoreOnInvalid(), |
There was a problem hiding this comment.
shouldn't we instead pass the request stack when the virtual one doesn't exist? that'd match the previous behavior
the solution might be to alias the virtual stack to the real one in FWB when not in debug, WDYT?
There was a problem hiding this comment.
I did that in a compiler pass now. Adding an alias is probably not a solution as long as we do not want to list older versions of the FrameworkBundle as a conflict.
|
Thank you @xabbuh. |
This was referenced Oct 29, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.