[HttpKernel] Improve PHPDoc on #[AsController] attribute
#52147
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
| @@ -12,7 +12,11 @@ | ||
| namespace Symfony\Component\HttpKernel\Attribute; | ||
|
|
||
| /** | ||
| * Service tag to autoconfigure controllers. | ||
| * To autoconfigure your controllers as serivces you can use |
There was a problem hiding this comment.
Thanks @muchafm. I like the improvement ... but I'd reword it and expand it a bit. For example:
* Autoconfigures controllers as services by applying the `controller.service_arguments`
* tag to them. This allows to inject services in controller action methods, not
* only in their constructors.
*
* @see https://symfony.com/doc/current/controller/service.html
There was a problem hiding this comment.
Oh I see, thank you for the suggestion, I will apply it
#[AsController] attribute
#[AsController] attribute#[AsController] attribute
0b4f9f6 to
d5c59e0
Compare
|
Thank you @muchafm. |
Improve PHPDoc on AsController attribute