Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[7.0] Cleanup legacy code paths #52142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2023
Merged

[7.0] Cleanup legacy code paths #52142

merged 1 commit into from
Oct 19, 2023

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Oct 18, 2023 •
edited
Loading

Q A
Branch? 7.0
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT

@carsonbot carsonbot added this to the 7.0 milestone Oct 18, 2023
nicolas-grekas
nicolas-grekas commented Oct 18, 2023
View reviewed changes
src/Symfony/Component/Routing/Loader/AttributeFileLoader.php Outdated
@@ -30,7 +30,7 @@ class AttributeFileLoader extends FileLoader
public function __construct(FileLocatorInterface $locator, AttributeClassLoader $loader)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this class in 7.0 BTW?

OskarStark
OskarStark reviewed Oct 18, 2023
View reviewed changes
src/Symfony/Component/Serializer/Annotation/Context.php Outdated Show resolved Hide resolved
@nicolas-grekas nicolas-grekas force-pushed the 7cleanup branch 4 times, most recently from cd4598d to 0e0dcf9 Compare October 19, 2023 09:44
@nicolas-grekas nicolas-grekas mentioned this pull request Oct 19, 2023
Closed
@nicolas-grekas nicolas-grekas force-pushed the 7cleanup branch 2 times, most recently from 9d5285f to c7e94c0 Compare October 19, 2023 14:03
@nicolas-grekas nicolas-grekas merged commit 6edf73d into symfony:7.0 Oct 19, 2023
@nicolas-grekas nicolas-grekas deleted the 7cleanup branch November 9, 2023 13:32
@vtsykun vtsykun mentioned this pull request Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @OskarStark @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.