[HttpKernel] Add option to map empty data with MapQueryString
and MapRequestPayload
#52134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice if the
RequestPayloadValueResolver
could optionally call theserializer->denormalize
method regardless if$request->query
,$request->request
or$request->getContent()
is empty.Because if a DTO/request has optional arguments combined with some system-provided arguments, the data could be empty while the controller may still require this DTO class.
Also in cases where there are only required arguments, it is beneficial for the user to see which request arguments are needed. The
PartialDenormalizationException
may show this.For example:
Where the
$userId
is provided by a custom normalizer that retrieves it from the Symfony Security User object. If$name
isn't passed in the request, the class won't be constructed.