Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Messenger][Amqp] Fix wrong routing key when use failure queue #52083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 6.3
Choose a base branch
Loading
from
Open

[Messenger][Amqp] Fix wrong routing key when use failure queue #52083

wants to merge 1 commit into from

Conversation

fabcdl
Copy link

@fabcdl fabcdl commented Oct 16, 2023 •
edited by OskarStark
Loading

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets #37985
License MIT

I would like to use another amqp queue for dead letter after retries failed. I expected the message to be sent to the failure transport queue. It wasn't.

My initial configuration:

framework:
    messenger:
        transports:
            async:
                dsn: '%env(MESSENGER_TRANSPORT_DSN)%'
                retry_strategy:
                    max_retries: 3
                    delay: 30000
                    multiplier: 2
                    max_delay: 300000
                failure_transport: failure
                options:
                    exchange:
                        type: direct
                        name: my_exchange_name
                        default_publish_routing_key: common
                    queues:
                        my_queue_name:
                            binding_keys: [common]
            failure:
                dsn: '%env(MESSENGER_TRANSPORT_DSN)%'
                options:
                    exchange:
                        type: direct
                        name: my_exchange_name
                        default_publish_routing_key: failed
                    queues:
                        my_failure_queue:
                            binding_keys: [failed]

I found the issue #37985 that already mentioned the problem. A workaround using queue name as routing key for failure queue is already proposed. It is not obvious...

binding_keys: [failed, my_queue_name]

After some debug, I found the routing key is not correctly set in case of failure transport. Exchange configuration is good but routing key uses previous routing key set by retry mechanism. And retry mechanism use queue name.

Routing key comes from RedeliveryStamp and uses async queue name as routing key. It is not what I expected. But I understand it is required by the retry mechanism to push delayed message to the original queue.

Finally I propose a little modification to take into account the SentToFailureTransportStamp and force to publish with the failure routing key by default.

I think this fix could be pushed to 5.4 but I didn't test it.

@carsonbot carsonbot added this to the 6.3 milestone Oct 16, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title [Messenger][Amqp] Fix wrong routing key when use failure queue [Messenger] [Amqp] Fix wrong routing key when use failure queue Oct 16, 2023
@OskarStark OskarStark changed the title [Messenger] [Amqp] Fix wrong routing key when use failure queue [Messenger][Amqp] Fix wrong routing key when use failure queue Oct 17, 2023
@fabcdl fabcdl force-pushed the fix-amqp-messenger-failure-queue-routing-key branch 2 times, most recently from 908a9f3 to a489cd5 Compare October 19, 2023 08:51
@fabcdl fabcdl force-pushed the fix-amqp-messenger-failure-queue-routing-key branch from a489cd5 to 4e1b8fc Compare October 19, 2023 08:55
@nicolas-grekas nicolas-grekas modified the milestones: 6.3, 6.4 Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

Assignees
No one assigned
Labels
Bug Messenger Status: Needs Review
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
3 participants
@fabcdl @carsonbot @nicolas-grekas
Morty Proxy This is a proxified and sanitized view of the page, visit original site.