Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[FrameworkBundle][RemoteEvent][Routing][Scheduler] Add PHPDoc to attributes properties #51996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2024
Merged

[FrameworkBundle][RemoteEvent][Routing][Scheduler] Add PHPDoc to attributes properties #51996

merged 1 commit into from
Feb 2, 2024

Conversation

alexandre-daubois
Copy link
Member

@alexandre-daubois alexandre-daubois commented Oct 11, 2023 •
edited
Loading

Q A
Branch? 7.1
Bug fix? no
New feature? no
Deprecations? no
Tickets Part of #51920
License MIT

@carsonbot carsonbot added this to the 6.4 milestone Oct 11, 2023
@alexandre-daubois alexandre-daubois force-pushed the remaining-attr-docs branch 2 times, most recently from 708e39f to 3e61550 Compare October 15, 2023 09:29
@alexandre-daubois
Copy link
Member Author

I addressed all your comments, thank you for the review

@GromNaN GromNaN mentioned this pull request Oct 18, 2023
Closed
@GromNaN GromNaN added the ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" label Nov 1, 2023
GromNaN
GromNaN reviewed Nov 1, 2023
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase, the file Route class have been moved by #52294

src/Symfony/Component/Routing/Annotation/Route.php Outdated Show resolved Hide resolved
src/Symfony/Component/Routing/Annotation/Route.php Outdated Show resolved Hide resolved
src/Symfony/Component/Routing/Annotation/Route.php Outdated Show resolved Hide resolved
@alexandre-daubois alexandre-daubois force-pushed the remaining-attr-docs branch 2 times, most recently from 193549f to e1ca70c Compare November 2, 2023 09:53
@alexandre-daubois
Copy link
Member Author

Thanks for the review @GromNaN, I addressed your comments 👍

GromNaN
GromNaN approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/Symfony/Component/Routing/Attribute/Route.php Outdated Show resolved Hide resolved
@alexandre-daubois alexandre-daubois force-pushed the remaining-attr-docs branch 2 times, most recently from d0bd1f4 to 0ffe6da Compare November 2, 2023 10:16
@nicolas-grekas nicolas-grekas removed the ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" label Nov 7, 2023
@nicolas-grekas nicolas-grekas modified the milestones: 6.4, 7.1 Nov 15, 2023
@alexandre-daubois alexandre-daubois force-pushed the remaining-attr-docs branch 2 times, most recently from 1f8763d to e03a5e4 Compare January 5, 2024 09:04
@alexandre-daubois alexandre-daubois force-pushed the remaining-attr-docs branch 2 times, most recently from 76788a5 to 7d28042 Compare January 5, 2024 09:06
@alexandre-daubois
Copy link
Member Author

alexandre-daubois commented Jan 5, 2024 •
edited
Loading

I updated with @param annotation and also avoid "sentences punctuation" by using ; where possible

@alexandre-daubois alexandre-daubois force-pushed the remaining-attr-docs branch 2 times, most recently from d858f24 to cf2372a Compare January 5, 2024 12:09
@fabpot
Copy link
Member

fabpot commented Feb 2, 2024

Thank you @alexandre-daubois.

@fabpot fabpot merged commit 5c7f4b0 into symfony:7.1 Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renanbr renanbr renanbr left review comments

@GromNaN GromNaN GromNaN approved these changes

@stof stof stof left review comments

@fabpot fabpot fabpot approved these changes

@kbond kbond kbond approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
FrameworkBundle RemoteEvent Routing Scheduler Status: Reviewed
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.
8 participants
@alexandre-daubois @fabpot @kbond @nicolas-grekas @renanbr @GromNaN @stof @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.