Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[HttpFoundation]  Improve PHPDoc of Cache attribute #51968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2023
Merged

[HttpFoundation]  Improve PHPDoc of Cache attribute #51968

merged 1 commit into from
Oct 11, 2023
+26 −3

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Oct 10, 2023

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Part of #51920
License MIT

@javiereguiluz was right to point out that the PHPDoc wasn't perfect.

@GromNaN GromNaN requested a review from javiereguiluz October 10, 2023 10:07
@carsonbot carsonbot changed the title [HttpFoundation] Improve PHPDoc of Cache attribute [HttpFoundation]  Improve PHPDoc of Cache attribute Oct 10, 2023
@carsonbot carsonbot added this to the 6.4 milestone Oct 10, 2023
@GromNaN GromNaN mentioned this pull request Oct 10, 2023
Closed
OskarStark
OskarStark reviewed Oct 10, 2023
View reviewed changes
src/Symfony/Component/HttpKernel/Attribute/Cache.php Outdated Show resolved Hide resolved
javiereguiluz
javiereguiluz reviewed Oct 10, 2023
View reviewed changes
src/Symfony/Component/HttpKernel/Attribute/Cache.php Outdated Show resolved Hide resolved
src/Symfony/Component/HttpKernel/Attribute/Cache.php Outdated Show resolved Hide resolved
OskarStark
OskarStark reviewed Oct 10, 2023
View reviewed changes
src/Symfony/Component/HttpKernel/Attribute/Cache.php Outdated Show resolved Hide resolved
javiereguiluz
javiereguiluz approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jérôme, thanks for this.

src/Symfony/Component/HttpKernel/Attribute/Cache.php Outdated Show resolved Hide resolved
@GromNaN
Copy link
Member Author

GromNaN commented Oct 11, 2023 •
edited
Loading

Thanks for your help @OskarStark @javiereguiluz. I realize @alexandre-daubois is much more productive than I am 🥇

@fabpot
Copy link
Member

fabpot commented Oct 11, 2023

Thank you @GromNaN.

@fabpot fabpot merged commit 732ef57 into symfony:6.4 Oct 11, 2023
@GromNaN GromNaN deleted the phpdoc-cache branch October 11, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
HttpFoundation Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
5 participants
@GromNaN @fabpot @javiereguiluz @OskarStark @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.