Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Thanks for submitting your first contribution to Symfony.
This code was necessary for the remember-me system to work before it was refactored. With the new implementation and the IS_IMPERSONATOR attribute, it is not needed anymore.
Even if it should have been removed in 6.0 given the role has been deprecated in 5.x, I think it is safer to do it for the next major version. And it has been done already in #50957.
So unfortunately I think we can close this PR.

/cc @wouterj in case you think otherwise

I agree. Also note that IS_IMPERSONATOR is an attribute, not a role, which is why #50957 didn't add it to the roles array but rather removes the deprecated ROLE_PREVIOUS_ADMIN role.