[AssetMapper] Fixing jsdelivr regex to catch 2x export syntax in a row #51728
+42
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures look unrelated |
stloyd
reviewed
Sep 23, 2023
src/Symfony/Component/AssetMapper/Tests/ImportMap/Resolver/JsDelivrEsmResolverTest.php
Outdated
Show resolved
Hide resolved
dunglas
approved these changes
Sep 26, 2023
src/Symfony/Component/AssetMapper/Tests/ImportMap/Resolver/JsDelivrEsmResolverTest.php
Outdated
Show resolved
Hide resolved
465f0fe to
2e6618b
Compare
|
Thank you @weaverryan. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I found a new variant on the import syntax used by jsdelivr. This updates the regex to cover it and enhances the test suite around this pattern matching. The source of the problem is this content: https://cdn.jsdelivr.net/npm/@vue/runtime-dom@3.3.4/+esm
Cheers!