Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Config] Allow to always use config classes #51544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: 7.4
Choose a base branch
Loading
from
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
- fix CI
  • Loading branch information
alexndlm committed Nov 11, 2023
commit 72e1fd059e620db04c5f4f2e3141fb0daa48d5ee
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,6 @@ public function NAME(string $VAR, TYPE $VALUE): static
$comment .= sprintf(' * @psalm-return (TValue is array ? %s : static)'."\n ", $childClass->getFqcn());
$comment = "/**\n$comment*/\n";


if (null === $key = $node->getKeyAttribute()) {
$body = '
COMMENTpublic function NAME(mixed $value = []): CLASS|static
Expand Down Expand Up @@ -545,9 +544,4 @@ private function hasNormalizationClosures(NodeInterface $node): bool

return [] !== $r->getValue($node);
}

private function getType(string $classType, bool $hasNormalizationClosures): string
{
return $classType.($hasNormalizationClosures ? '|scalar' : '');
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ protected function createNode(): NodeInterface

if ($this->default) {
if (!\is_array($this->defaultValue)) {
throw new \InvalidArgumentException(sprintf('%s: the default value of an array node has to be an array.', $node->getPath()));
throw new \InvalidArgumentException(sprintf('"%s": the default value of an array node has to be an array.', $node->getPath()));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be reverted, that's a false-positive from fabbot I suppose

}

$node->setDefaultValue($this->defaultValue);
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.